Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add --cwd CLI option #6964

Merged
merged 2 commits into from
Nov 7, 2022
Merged

feat: Add --cwd CLI option #6964

merged 2 commits into from
Nov 7, 2022

Conversation

WillDaSilva
Copy link
Member

Closes #6943

@netlify
Copy link

netlify bot commented Nov 7, 2022

Deploy Preview for meltano canceled.

Name Link
🔨 Latest commit b3c21f1
🔍 Latest deploy log https://app.netlify.com/sites/meltano/deploys/63694d6f30261c0008551e54

@WillDaSilva WillDaSilva marked this pull request as ready for review November 7, 2022 18:07
@codecov
Copy link

codecov bot commented Nov 7, 2022

Codecov Report

Merging #6964 (b3c21f1) into main (147d3ba) will increase coverage by 0.03%.
The diff coverage is 93.54%.

@@            Coverage Diff             @@
##             main    #6964      +/-   ##
==========================================
+ Coverage   88.73%   88.76%   +0.03%     
==========================================
  Files         284      284              
  Lines       20542    20573      +31     
  Branches     2027     2028       +1     
==========================================
+ Hits        18228    18262      +34     
+ Misses       1979     1976       -3     
  Partials      335      335              
Impacted Files Coverage Δ
src/meltano/cli/cli.py 85.54% <75.00%> (-1.13%) ⬇️
tests/meltano/cli/test_cli.py 100.00% <100.00%> (ø)
src/meltano/cli/utils.py 83.80% <0.00%> (+1.05%) ⬆️
src/meltano/cli/dragon.py 100.00% <0.00%> (+20.00%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@edgarrmondragon edgarrmondragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I re-ran the flaky tests and they passed.

:shipit:

@WillDaSilva WillDaSilva merged commit 67e4ec1 into main Nov 7, 2022
@WillDaSilva WillDaSilva deleted the 6943-cwd-cli-option branch November 7, 2022 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: --cwd CLI option
2 participants