Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct meltano config behavior when explicit environment is provided #6997

Merged
merged 4 commits into from Nov 18, 2022

Conversation

cjohnhanson
Copy link
Contributor

Closes #6512

@cjohnhanson cjohnhanson requested a review from a team November 16, 2022 22:39
@netlify
Copy link

netlify bot commented Nov 16, 2022

Deploy Preview for meltano ready!

Name Link
🔨 Latest commit e29e558
🔍 Latest deploy log https://app.netlify.com/sites/meltano/deploys/6376b622b38ef300083025da
😎 Deploy Preview https://deploy-preview-6997--meltano.netlify.app/getting-started/installation
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Nov 16, 2022

Codecov Report

Merging #6997 (e29e558) into main (927fc0f) will decrease coverage by 0.02%.
The diff coverage is 68.96%.

@@            Coverage Diff             @@
##             main    #6997      +/-   ##
==========================================
- Coverage   88.68%   88.66%   -0.03%     
==========================================
  Files         292      292              
  Lines       21278    21307      +29     
  Branches     2101     2105       +4     
==========================================
+ Hits        18871    18892      +21     
- Misses       2052     2059       +7     
- Partials      355      356       +1     
Impacted Files Coverage Δ
src/meltano/cli/config.py 70.37% <68.00%> (-0.28%) ⬇️
tests/meltano/cli/test_config.py 89.47% <75.00%> (-0.81%) ⬇️
src/meltano/core/plugin_discovery_service.py 89.34% <0.00%> (+0.59%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

src/meltano/cli/config.py Show resolved Hide resolved
src/meltano/cli/config.py Outdated Show resolved Hide resolved
src/meltano/cli/config.py Outdated Show resolved Hide resolved
src/meltano/cli/config.py Outdated Show resolved Hide resolved
@cjohnhanson cjohnhanson merged commit 835262d into main Nov 18, 2022
@cjohnhanson cjohnhanson deleted the 6512-meltano-config-envs branch November 18, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Conflicting behavior flags in meltano config set
3 participants