Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update custom extractor Poetry instructions #7035

Merged
merged 2 commits into from Nov 29, 2022
Merged

docs: Update custom extractor Poetry instructions #7035

merged 2 commits into from Nov 29, 2022

Conversation

EMCP
Copy link
Contributor

@EMCP EMCP commented Nov 29, 2022

the build and publish command have been changed in poetry

the build and publish command have been changed in poetry
@EMCP EMCP requested review from afolson, tayloramurphy and a team as code owners November 29, 2022 17:33
@netlify
Copy link

netlify bot commented Nov 29, 2022

👷 Deploy request for meltano pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit fe5d68d

@EMCP
Copy link
Contributor Author

EMCP commented Nov 29, 2022

@afolson , thanks for the quick response.. hope this format works otherwise I can use the multi line ```bash approach

like
so

@afolson
Copy link
Contributor

afolson commented Nov 29, 2022

@edgarrmondragon Is this the best way to do this now? Looks like --build was deprecated a bit ago.

@WillDaSilva WillDaSilva changed the title Update custom-extractor.md docs: Update custom extractor Poetry instructions Nov 29, 2022
@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Merging #7035 (1df3232) into main (e319251) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 1df3232 differs from pull request most recent head fe5d68d. Consider uploading reports for the commit fe5d68d to get more accurate results

@@            Coverage Diff             @@
##             main    #7035      +/-   ##
==========================================
- Coverage   88.65%   88.63%   -0.02%     
==========================================
  Files         292      292              
  Lines       21318    21318              
  Branches     2106     2106              
==========================================
- Hits        18899    18896       -3     
- Misses       2061     2063       +2     
- Partials      358      359       +1     
Impacted Files Coverage Δ
src/meltano/cli/elt.py 93.85% <0.00%> (-1.12%) ⬇️
src/meltano/core/elt_context.py 95.86% <0.00%> (-0.69%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@edgarrmondragon
Copy link
Collaborator

@edgarrmondragon Is this the best way to do this now? Looks like --build was deprecated a bit ago.

@afolson yup, the official docs now use commands build and publish

@edgarrmondragon
Copy link
Collaborator

Thanks @EMCP!

@edgarrmondragon edgarrmondragon merged commit 4d6dae4 into meltano:main Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants