New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Expand UI deprecation description #7041
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qbatten
requested review from
afolson,
tayloramurphy and
a team
as code owners
November 30, 2022 22:40
|
Name | Link |
---|---|
🔨 Latest commit | 02dc112 |
Codecov Report
@@ Coverage Diff @@
## main #7041 +/- ##
=======================================
Coverage 88.65% 88.65%
=======================================
Files 292 292
Lines 21304 21304
Branches 2106 2106
=======================================
Hits 18887 18887
Misses 2060 2060
Partials 357 357 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
edgarrmondragon
requested changes
Nov 30, 2022
aaronsteers
reviewed
Dec 1, 2022
Co-authored-by: Edgar R. M. <edgarrm358@gmail.com>
Co-authored-by: Edgar R. M. <edgarrm358@gmail.com>
Co-authored-by: Edgar R. M. <edgarrm358@gmail.com>
Co-authored-by: Aaron ("AJ") Steers <aj@meltano.com>
Just noticed that you can commit suggestions together in a batch haha. Those commits'll all get squashed on merge I guess. All changes looked good to me! |
edgarrmondragon
approved these changes
Dec 1, 2022
afolson
approved these changes
Dec 2, 2022
@qbatten This looks great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small docs PR to resolve issue #7038, per convo in office hours on 11/30. Thanks to @SBurwash for pointing out that the Airflow webserver can replace nearly all Meltano UI functionality.
Maintainers please do add or edit, I wasn't sure what other features are/aren't supported by UI, nor do I know the details of how the UI/environments interact, just think I remember someone saying they dont play nice together. Thanks!