Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Distribute Meltano with a dependency on a compatible SQLite binary #7143

Open
edgarrmondragon opened this issue Jan 3, 2023 · 5 comments

Comments

@edgarrmondragon
Copy link
Collaborator

Meltano should be shipped with the version of SQLite it expects to work with fine out of the box. Adding a dependency on https://pypi.org/project/pysqlite3-binary might be worth exploring, although it's lacking wheels for macOS and Windows at the moment.

Originally posted by @edgarrmondragon in #6405 (comment)

@stale
Copy link

stale bot commented May 4, 2023

This has been marked as stale because it is unassigned, and has not had recent activity. It will be closed after 21 days if no further activity occurs. If this should never go stale, please add the evergreen label, or request that it be added.

@stale stale bot added the stale label May 4, 2023
@WillDaSilva
Copy link
Member

This is still relevant. Today while running Meltano in an AWS Lambda Docker container I received this error message:

Detected SQLite 3.7.17, but Meltano requires at least 3.25.1. Upgrade your database to be compatible with Meltano or use a different database.

It'd certainly be nice if Meltano didn't have this implicit dependency.

@stale stale bot removed the stale label May 16, 2023
@edgarrmondragon
Copy link
Collaborator Author

Too bad the maintainer doesn't want to publish macOS and Windows wheels at the moment: coleifer/pysqlite3#42 (comment)

@edgarrmondragon
Copy link
Collaborator Author

sqlean.py seems like a good alternative

@edgarrmondragon
Copy link
Collaborator Author

Ok, here's an approach that works:

pipx install meltano --python python3.10 --suffix=@sqlean
pipx inject meltano@sqlean sqlean-driver
meltano@sqlean init poc-sqlean
cd poc-sqlean
meltano@sqlean config config meltano set database_uri 'sqlite+sqlean:///$MELTANO_SYS_DIR_ROOT/meltano.db' --store=meltano_yml

to confirm that we got a recent SQLite:

$ ~/.local/pipx/venvs/meltano@sqlean/bin/python -c 'import sqlean; print(sqlean.sqlite_version)'
3.42.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants