Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meltano should treat plugins as 'custom' if no variant is provided #7305

Open
aaronsteers opened this issue Feb 13, 2023 · 4 comments
Open
Labels
kind/Bug Something isn't working valuestream/Meltano

Comments

@aaronsteers
Copy link
Contributor

aaronsteers commented Feb 13, 2023

Note:

  • This is a 'bug' but also working as historically designed. I'm leaving 'bug' out of the title for now, but we can think of this either as a 'bug' or as a refactor to catch up with 2.0-related design changes. where meltano.yml was deprecated and the Hub and the lockfiles became primary source of record.

Related to deprecation of namespace, this issue came up recently in #7296, where a plugin is reaching out to the Hub to find a plugin definition.

If variant is not provided in the meltano.yml file, then searching for a lockfile will necessarily fail, as will the lookup to Hub. Hence, I think we can treat those as always 'custom'.

@edgarrmondragon @aaronsteers This may be caused by the variant not being specified in meltano.yml: https://meltano.slack.com/archives/C01TCRBBJD7/p1676044092702169?thread_ts=1675952792.259879&cid=C01TCRBBJD7

Originally posted by @WillDaSilva in #7296 (comment)

@tayloramurphy
Copy link
Collaborator

Since you mentioned the namespace issue:

@tayloramurphy tayloramurphy added kind/Bug Something isn't working valuestream/Meltano labels Feb 13, 2023
@aaronsteers
Copy link
Contributor Author

Thanks! I had that issue top of mind, but couldn't find the link. 😅

@stale
Copy link

stale bot commented Jun 13, 2023

This has been marked as stale because it is unassigned, and has not had recent activity. It will be closed after 21 days if no further activity occurs. If this should never go stale, please add the evergreen label, or request that it be added.

@stale stale bot added the stale label Jun 13, 2023
@WillDaSilva
Copy link
Member

Still relevant

@stale stale bot removed the stale label Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/Bug Something isn't working valuestream/Meltano
Projects
None yet
Development

No branches or pull requests

3 participants