Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Merge environment-level annotations into top level in manifest #7331

Merged
merged 5 commits into from
Feb 21, 2023

Conversation

WillDaSilva
Copy link
Member

@WillDaSilva WillDaSilva commented Feb 16, 2023

Closes #7330

@WillDaSilva WillDaSilva self-assigned this Feb 16, 2023
@WillDaSilva WillDaSilva requested review from a team as code owners February 16, 2023 21:38
@netlify
Copy link

netlify bot commented Feb 16, 2023

Deploy Preview for meltano ready!

Name Link
🔨 Latest commit 583fcf2
🔍 Latest deploy log https://app.netlify.com/sites/meltano/deploys/63f4e013f1ab2400083308e9
😎 Deploy Preview https://deploy-preview-7331--meltano.netlify.app/getting-started/installation
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Merging #7331 (b7bc6cd) into main (85b5f2d) will decrease coverage by 0.01%.
The diff coverage is 33.33%.

❗ Current head b7bc6cd differs from pull request most recent head 583fcf2. Consider uploading reports for the commit 583fcf2 to get more accurate results

@@            Coverage Diff             @@
##             main    #7331      +/-   ##
==========================================
- Coverage   89.01%   89.00%   -0.01%     
==========================================
  Files         293      293              
  Lines       21682    21685       +3     
  Branches     2428     2429       +1     
==========================================
+ Hits        19300    19301       +1     
- Misses       2009     2010       +1     
- Partials      373      374       +1     
Impacted Files Coverage Δ
src/meltano/core/manifest/manifest.py 93.02% <33.33%> (-1.43%) ⬇️
src/meltano/cli/compile.py 89.47% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@WillDaSilva WillDaSilva merged commit 3fda9fe into main Feb 21, 2023
@WillDaSilva WillDaSilva deleted the 7330-preserve-environment-annotations branch February 21, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: environment-level annotations are missing from manifest
2 participants