Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improve config JSON array/object error message and parser #7344

Merged
merged 5 commits into from
Feb 23, 2023

Conversation

WillDaSilva
Copy link
Member

Closes #7339

@WillDaSilva WillDaSilva self-assigned this Feb 22, 2023
@netlify
Copy link

netlify bot commented Feb 22, 2023

Deploy Preview for meltano canceled.

Name Link
🔨 Latest commit 8bd74b3
🔍 Latest deploy log https://app.netlify.com/sites/meltano/deploys/63f695cf5fe34b0008cba739

@codecov
Copy link

codecov bot commented Feb 22, 2023

Codecov Report

Merging #7344 (8bd74b3) into main (2ba4720) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #7344      +/-   ##
==========================================
+ Coverage   88.82%   88.85%   +0.02%     
==========================================
  Files         293      294       +1     
  Lines       21698    21720      +22     
  Branches     2451     2452       +1     
==========================================
+ Hits        19274    19299      +25     
  Misses       2032     2032              
+ Partials      392      389       -3     
Impacted Files Coverage Δ
src/meltano/core/setting_definition.py 93.95% <100.00%> (+4.82%) ⬆️
tests/meltano/core/test_setting_definition.py 100.00% <100.00%> (ø)
src/meltano/cli/utils.py 84.39% <0.00%> (-0.96%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@WillDaSilva WillDaSilva marked this pull request as ready for review February 22, 2023 17:03
@WillDaSilva WillDaSilva merged commit 39a10d5 into main Feb 23, 2023
@WillDaSilva WillDaSilva deleted the 7339-improve-config-err-msg-and-parser branch February 23, 2023 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants