Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: meltano install --parallelism error #7371

Merged
merged 1 commit into from
Mar 13, 2023
Merged

Conversation

WillDaSilva
Copy link
Member

@WillDaSilva WillDaSilva commented Mar 12, 2023

The update to the tests should prevent another regression like this.

Closes #7370

@netlify
Copy link

netlify bot commented Mar 12, 2023

Deploy Preview for meltano canceled.

Name Link
🔨 Latest commit 5a4fe2f
🔍 Latest deploy log https://app.netlify.com/sites/meltano/deploys/640e540939a82f0008da608e

@codecov
Copy link

codecov bot commented Mar 12, 2023

Codecov Report

Merging #7371 (5a4fe2f) into main (58b40c5) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #7371      +/-   ##
==========================================
+ Coverage   89.06%   89.08%   +0.02%     
==========================================
  Files         294      294              
  Lines       21685    21689       +4     
  Branches     2433     2433              
==========================================
+ Hits        19314    19322       +8     
+ Misses       2002     2000       -2     
+ Partials      369      367       -2     
Impacted Files Coverage Δ
src/meltano/core/plugin_install_service.py 88.11% <100.00%> (+2.50%) ⬆️
tests/meltano/core/test_plugin_install_service.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@WillDaSilva WillDaSilva merged commit 6b63249 into main Mar 13, 2023
@WillDaSilva WillDaSilva deleted the 7370-fix-parallel-install branch March 13, 2023 17:49
@aaronsteers
Copy link
Contributor

@WillDaSilva - Thanks so much for tackling this!

Much appreciated. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: --parallelism flag not working in latest version of meltano
3 participants