Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Display the right message when adding a new variant of an existing plugin #7399

Merged

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon requested a review from a team as a code owner March 17, 2023 22:32
@edgarrmondragon edgarrmondragon linked an issue Mar 17, 2023 that may be closed by this pull request
@netlify
Copy link

netlify bot commented Mar 17, 2023

Deploy Preview for meltano canceled.

Name Link
🔨 Latest commit 96b5453
🔍 Latest deploy log https://app.netlify.com/sites/meltano/deploys/6414ea7db1d5580008430890

@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Merging #7399 (96b5453) into main (dec526b) will increase coverage by 0.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #7399      +/-   ##
==========================================
+ Coverage   89.11%   89.20%   +0.09%     
==========================================
  Files         294      294              
  Lines       21690    21702      +12     
  Branches     2438     2439       +1     
==========================================
+ Hits        19328    19360      +32     
+ Misses       1995     1976      -19     
+ Partials      367      366       -1     
Impacted Files Coverage Δ
src/meltano/cli/utils.py 91.63% <100.00%> (+6.43%) ⬆️
src/meltano/core/project_plugins_service.py 91.01% <100.00%> (+0.05%) ⬆️
tests/meltano/cli/test_add.py 95.68% <100.00%> (+0.19%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@edgarrmondragon edgarrmondragon merged commit 25aab6b into main Mar 20, 2023
@edgarrmondragon edgarrmondragon deleted the 7392-bug-plugin-name-exists-still-throws-not-known branch March 20, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Plugin name exists still throws "not known"
2 participants