Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add correct type for state_backend lock settings #7537

Merged
merged 6 commits into from
Apr 13, 2023

Conversation

cjohnhanson
Copy link
Contributor

Also reduces default lock timeout to a more reasonable 10 seconds.

Closes #7525

@cjohnhanson cjohnhanson requested a review from a team April 13, 2023 00:25
@netlify
Copy link

netlify bot commented Apr 13, 2023

Deploy Preview for meltano canceled.

Name Link
🔨 Latest commit de3cbf1
🔍 Latest deploy log https://app.netlify.com/sites/meltano/deploys/64388763caea070008c9b72c

@WillDaSilva
Copy link
Member

@cjohnhanson You'll have to regenerate the sample manifest files to get the integration tests passing.

@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Merging #7537 (04260a9) into main (0be994f) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 04260a9 differs from pull request most recent head de3cbf1. Consider uploading reports for the commit de3cbf1 to get more accurate results

@@           Coverage Diff           @@
##             main    #7537   +/-   ##
=======================================
  Coverage   89.40%   89.40%           
=======================================
  Files         294      294           
  Lines       21684    21684           
  Branches     2426     2426           
=======================================
+ Hits        19386    19387    +1     
+ Misses       1939     1938    -1     
  Partials      359      359           

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cjohnhanson cjohnhanson merged commit f100350 into main Apr 13, 2023
38 checks passed
@cjohnhanson cjohnhanson deleted the 7525-state-backend-config-parsing branch April 13, 2023 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: State backend lock settings parsed as strings
4 participants