Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: refresh getting started guide #7678

Merged
merged 3 commits into from
May 19, 2023
Merged

Conversation

pnadolny13
Copy link
Contributor

I re-read through the getting started guide after someone reported seeing issues in slack https://meltano.slack.com/archives/C01TCRBBJD7/p1684327364192699 and I noticed its quite out dated especially when it comes to the dbt parts.

I've noticed that more and more people are reporting issues with dbt and airflow when using the original transformer/orchestrator plugin types but once they switch to utilities their problems are resolved. Ideally we'd get all our docs cleaned up to improve the onboarding experience.

  • removed $ from the commands because they were inconsistent and made it hard to copy and paste
  • refresh some outputs and configs since the plugins have changed over time
  • the tutorial starts by using sbalnojan/meltano-lightdash as the repo then switched to sbalnojan/meltano-example-el. I think this was a bug because there was no text telling the user to switch their configs.
  • dbt utility instead of transformer
  • the first dbt invoke command threw an error because it never told the user to run a tap/target sync after updating the selection critieria to "*". The commit column didnt exist for me.
  • The docker command to start postgres needs to assign a name so later we can use it in the exec commands. Previously the postgres container was getting a randomly generated name.
  • Also for the docker commands to drop tables we didnt provide a database name so I was getting errors like "table not found"
  • Add an sample of the data for the mapper section to clarify what its doing.

TODO:

  • the numbers arent rendering properly in the current version or my version but I couldnt get them to increment properly

@netlify
Copy link

netlify bot commented May 17, 2023

Deploy Preview for meltano ready!

Name Link
🔨 Latest commit b2c1fcd
🔍 Latest deploy log https://app.netlify.com/sites/meltano/deploys/64678b6e09b77900087214ea
😎 Deploy Preview https://deploy-preview-7678--meltano.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Collaborator

@tayloramurphy tayloramurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pnadolny13 this looks great - thanks for getting it updated. One minor change, the very first command is meltano --version - can you update that the latest version?

@pnadolny13 pnadolny13 enabled auto-merge (squash) May 19, 2023 14:45
@pnadolny13 pnadolny13 merged commit d179f1b into main May 19, 2023
9 of 10 checks passed
@pnadolny13 pnadolny13 deleted the getting_started_guide_refresh branch May 19, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants