Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Compatibility with SQLAlchemy 2 #7960

Merged
merged 2 commits into from
Jul 27, 2023
Merged

refactor: Compatibility with SQLAlchemy 2 #7960

merged 2 commits into from
Jul 27, 2023

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Jul 27, 2023 •
edited

@codecov
Copy link

codecov bot commented Jul 27, 2023 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (cloud@0328495). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             cloud    #7960   +/-   ##
========================================
  Coverage         ?   90.38%           
========================================
  Files            ?      283           
  Lines            ?    21117           
  Branches         ?     2351           
========================================
  Hits             ?    19087           
  Misses           ?     1680           
  Partials         ?      350

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@edgarrmondragon edgarrmondragon marked this pull request as ready for review July 27, 2023 22:10
@edgarrmondragon edgarrmondragon requested review from WillDaSilva and a team as code owners July 27, 2023 22:10
@edgarrmondragon edgarrmondragon mentioned this pull request Jul 27, 2023
Closed
WillDaSilva
WillDaSilva approved these changes Jul 27, 2023
View reviewed changes
Copy link
Member

@WillDaSilva WillDaSilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Looks like the number of warnings has not changed significantly from this PR:

@edgarrmondragon
Copy link
Collaborator Author

💯

Looks like the number of warnings has not changed significantly from this PR:

Yeah, lots of warnings were raised after setting SQLALCHEMY_WARN_20 in da38fb4:

@edgarrmondragon edgarrmondragon merged commit 09ebdce into cloud Jul 27, 2023
35 checks passed
@edgarrmondragon edgarrmondragon deleted the sqlalchemy2 branch July 27, 2023 22:23
This was referenced Jul 27, 2023
Merged
Merged
Merged
Merged
@edgarrmondragon edgarrmondragon mentioned this pull request Aug 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillDaSilva WillDaSilva WillDaSilva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@edgarrmondragon @WillDaSilva