Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Support psycopg[binary] under a new postgres extra #7981

Merged
merged 11 commits into from
Aug 4, 2023

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Aug 1, 2023

Updated Docs:

About the psycopg 3 SQLAlchemy driver:

This driver is different enough from its psycopg2 predecessor that SQLAlchemy supports it via a totally separate dialect; support for psycopg2 is expected to remain for as long as that package continues to function for modern Python versions, and also remains the default dialect for the postgresql:// dialect series.

https://docs.sqlalchemy.org/en/20/dialects/postgresql.html#module-sqlalchemy.dialects.postgresql.psycopg

@netlify
Copy link

netlify bot commented Aug 1, 2023

Deploy Preview for meltano ready!

Name Link
🔨 Latest commit 1fd3152
🔍 Latest deploy log https://app.netlify.com/sites/meltano/deploys/64cd4f92226ed800088bc3a9
😎 Deploy Preview https://deploy-preview-7981--meltano.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #7981 (1fd3152) into cloud (1502ad6) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##            cloud    #7981      +/-   ##
==========================================
+ Coverage   90.43%   90.44%   +0.01%     
==========================================
  Files         283      284       +1     
  Lines       21124    21149      +25     
  Branches     2342     2345       +3     
==========================================
+ Hits        19103    19128      +25     
  Misses       1674     1674              
  Partials      347      347              
Files Changed Coverage Δ
tests/conftest.py 92.15% <100.00%> (+0.15%) ⬆️
tests/fixtures/db/postgresql_psycopg3.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@edgarrmondragon edgarrmondragon marked this pull request as ready for review August 4, 2023 18:06
docs/docs/guide/v3-migration.md Outdated Show resolved Hide resolved
Co-authored-by: Will Da Silva <will@willdasilva.xyz>
Copy link
Collaborator

@tayloramurphy tayloramurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice update - Docs look good too!

@edgarrmondragon edgarrmondragon merged commit 1340e69 into cloud Aug 4, 2023
45 checks passed
@edgarrmondragon edgarrmondragon deleted the feat/psycopg3 branch August 4, 2023 23:59
@edgarrmondragon edgarrmondragon linked an issue Aug 10, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to v3 of psycopg and psycopg[binary]
3 participants