Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use hyphens consistently for CLI options #7982

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

WillDaSilva
Copy link
Member

This is not a breaking change. All old CLI options will still work thanks to the normalization the CLI now does to the CLI option names.

Closes #2253

This is not a breaking change. All old CLI options will still work thanks to the normalization the CLI now does to the CLI option names.

Closes #2253
@WillDaSilva WillDaSilva self-assigned this Aug 1, 2023
@netlify
Copy link

netlify bot commented Aug 1, 2023

Deploy Preview for meltano ready!

Name Link
🔨 Latest commit bbff884
🔍 Latest deploy log https://app.netlify.com/sites/meltano/deploys/64c95532c6e0e50008f65cf9
😎 Deploy Preview https://deploy-preview-7982--meltano.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #7982 (bbff884) into main (c3cae1d) will not change coverage.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #7982   +/-   ##
=======================================
  Coverage   89.47%   89.47%           
=======================================
  Files         295      295           
  Lines       21791    21791           
  Branches     2440     2441    +1     
=======================================
  Hits        19498    19498           
  Misses       1937     1937           
  Partials      356      356           
Files Changed Coverage Δ
src/meltano/cli/cli.py 83.78% <ø> (ø)
src/meltano/cli/initialize.py 89.18% <ø> (ø)
src/meltano/cli/upgrade.py 98.11% <ø> (ø)
tests/meltano/cli/test_initialize.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@edgarrmondragon edgarrmondragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@WillDaSilva WillDaSilva merged commit b005812 into main Aug 2, 2023
43 checks passed
@WillDaSilva WillDaSilva deleted the 2253-cli-hyphens-not-underscores branch August 2, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consistently use hyphens in CLI parameter names rather than underscores
3 participants