Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): Add meltano config --unsafe flag #7984

Merged
merged 5 commits into from
Aug 2, 2023

Conversation

ReubenFrankel
Copy link
Contributor

Essentially bypasses behaviour changes made in #7878 to expose sensitive setting values with --unsafe, as per this request on Slack by @visch.

@netlify
Copy link

netlify bot commented Aug 1, 2023

Deploy Preview for meltano ready!

Name Link
🔨 Latest commit 4639dc5
🔍 Latest deploy log https://app.netlify.com/sites/meltano/deploys/64ca88dfdb11a600085e6ffb
😎 Deploy Preview https://deploy-preview-7984--meltano.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ReubenFrankel
Copy link
Contributor Author

Didn't know whether to keep the yellow styling for sensitive values when they are exposed (as a kind of reminder that the value is still sensitive) or not, so I just made it output what it otherwise would have before #7878. Pretty easy to change if anyone feels strongly.

@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #7984 (501ce31) into main (c3cae1d) will increase coverage by 0.00%.
Report is 5 commits behind head on main.
The diff coverage is 95.83%.

❗ Current head 501ce31 differs from pull request most recent head 4639dc5. Consider uploading reports for the commit 4639dc5 to get more accurate results

@@           Coverage Diff           @@
##             main    #7984   +/-   ##
=======================================
  Coverage   89.47%   89.48%           
=======================================
  Files         295      295           
  Lines       21791    21810   +19     
  Branches     2440     2441    +1     
=======================================
+ Hits        19498    19517   +19     
  Misses       1937     1937           
  Partials      356      356           
Files Changed Coverage Δ
src/meltano/cli/cli.py 83.78% <ø> (ø)
src/meltano/cli/initialize.py 89.18% <ø> (ø)
src/meltano/cli/upgrade.py 98.11% <ø> (ø)
src/meltano/cli/interactive/config.py 29.94% <75.00%> (+0.71%) ⬆️
src/meltano/cli/config.py 71.48% <100.00%> (+0.35%) ⬆️
tests/meltano/cli/test_config.py 92.30% <100.00%> (+1.19%) ⬆️
tests/meltano/cli/test_initialize.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@edgarrmondragon edgarrmondragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ReubenFrankel ReubenFrankel requested review from sbalnojan and a team as code owners August 2, 2023 16:48
@edgarrmondragon edgarrmondragon changed the title feat: Add meltano config --unsafe flag feat(cli): Add meltano config --unsafe flag Aug 2, 2023
@edgarrmondragon edgarrmondragon merged commit ff4aeb6 into meltano:main Aug 2, 2023
41 checks passed
@ReubenFrankel ReubenFrankel deleted the feature/config-unsafe branch August 2, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants