Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add meltano hub ping command #7989

Merged
merged 2 commits into from
Aug 2, 2023
Merged

feat: Add meltano hub ping command #7989

merged 2 commits into from
Aug 2, 2023

Conversation

WillDaSilva
Copy link
Member

@WillDaSilva WillDaSilva commented Aug 2, 2023

Closes #7988

@WillDaSilva WillDaSilva self-assigned this Aug 2, 2023
@netlify
Copy link

netlify bot commented Aug 2, 2023

Deploy Preview for meltano canceled.

Name Link
🔨 Latest commit 07b965f
🔍 Latest deploy log https://app.netlify.com/sites/meltano/deploys/64ca9df68b03030008dd9271

@WillDaSilva WillDaSilva marked this pull request as ready for review August 2, 2023 18:18
@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #7989 (07b965f) into main (ff4aeb6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #7989   +/-   ##
=======================================
  Coverage   89.48%   89.49%           
=======================================
  Files         295      297    +2     
  Lines       21810    21849   +39     
  Branches     2441     2442    +1     
=======================================
+ Hits        19517    19554   +37     
- Misses       1937     1939    +2     
  Partials      356      356           
Files Changed Coverage Δ
src/meltano/cli/__init__.py 85.91% <100.00%> (+0.20%) ⬆️
src/meltano/cli/hub.py 100.00% <100.00%> (ø)
tests/meltano/cli/test_hub.py 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@tayloramurphy tayloramurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it out - love it!

@WillDaSilva WillDaSilva merged commit 20260dd into main Aug 2, 2023
43 checks passed
@WillDaSilva WillDaSilva deleted the 7988-hub-ping branch August 2, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add meltano hub ping command
3 participants