-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for mappers in the invoke command #7992
Conversation
✅ Deploy Preview for meltano ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
It looks like at this point the only check failing is precommit which is saying the method is too complex. I can quickly refactor that method but it will ballon the diff of this PR a bit. Let me know what you would like me to do. |
Codecov Report
@@ Coverage Diff @@
## main #7992 +/- ##
=======================================
Coverage 89.53% 89.53%
=======================================
Files 297 297
Lines 21897 21903 +6
Branches 2441 2443 +2
=======================================
+ Hits 19605 19611 +6
Misses 1936 1936
Partials 356 356
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
@pnadolny13 Should the docs in https://docs.meltano.com/guide/mappers/ be updated? I think at least the FAQ section should, wdyt? |
@edgarrmondragon good point, I'll update that and see if theres other docs that can be updated too. |
@edgarrmondragon I updated the docs. One final review then I think this should be good to merge! |
Co-authored-by: Edgar R. M. <edgar@meltano.com>
|
Closes #3232
I'm not sure if theres a better way to get the mapping_name from a plugin object but this properly finds the mapper/mapping from my testing. I was able to run
cat github_out.json | meltano invoke hide-github-mails
using the tutorial mapper example to hash github emails and everything worked as expected.UPDATE: it looks like we do a similar lookup for mapping_name in
meltano/src/meltano/core/project_plugins_service.py
Line 306 in e8b9601