Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add el command as an alias of elt and depecrate both elt and the --transform option #7997

Merged
merged 16 commits into from
Aug 10, 2023
Merged

feat: Add el command as an alias of elt and depecrate both elt and the --transform option #7997

merged 16 commits into from
Aug 10, 2023

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Aug 4, 2023 •
edited

@netlify
Copy link

netlify bot commented Aug 4, 2023 •
edited

✅ Deploy Preview for meltano canceled.

Name Link
🔨 Latest commit 1c18b8b
🔍 Latest deploy log https://app.netlify.com/sites/meltano/deploys/64d4ff9720733c0008f5d23c

@codecov
Copy link

codecov bot commented Aug 5, 2023 •
edited

Codecov Report

Merging #7997 (1c18b8b) into main (3184a24) will increase coverage by 0.02%.
Report is 3 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #7997      +/-   ##
==========================================
+ Coverage   89.50%   89.53%   +0.02%     
==========================================
  Files         297      297              
  Lines       21849    21897      +48     
  Branches     2442     2441       -1     
==========================================
+ Hits        19557    19605      +48     
  Misses       1936     1936              
  Partials      356      356
Files Changed Coverage Δ
src/meltano/cli/__init__.py 86.11% <100.00%> (+0.19%) ⬆️
src/meltano/cli/elt.py 95.07% <100.00%> (+0.95%) ⬆️
tests/meltano/cli/test_elt.py 96.45% <100.00%> (+0.14%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@edgarrmondragon edgarrmondragon marked this pull request as ready for review August 8, 2023 21:00
@edgarrmondragon edgarrmondragon marked this pull request as draft August 8, 2023 21:02
@edgarrmondragon edgarrmondragon marked this pull request as ready for review August 8, 2023 23:27
WillDaSilva
WillDaSilva approved these changes Aug 9, 2023
View reviewed changes
Copy link
Member

@WillDaSilva WillDaSilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean as always @edgarrmondragon 👍

@edgarrmondragon edgarrmondragon linked an issue Aug 10, 2023 that may be closed by this pull request
Emit deprecation warning when elt command is used instead of el #7617
Closed
@edgarrmondragon edgarrmondragon changed the title feat!: Add el command as an alias of elt and depecrate both elt and the --transform option feat: Add el command as an alias of elt and depecrate both elt and the --transform option Aug 10, 2023
@edgarrmondragon edgarrmondragon merged commit a704ec0 into main Aug 10, 2023
43 checks passed
@edgarrmondragon edgarrmondragon deleted the el-command branch August 10, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillDaSilva WillDaSilva WillDaSilva approved these changes

@sbalnojan sbalnojan Awaiting requested review from sbalnojan

@tayloramurphy tayloramurphy Awaiting requested review from tayloramurphy tayloramurphy is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Emit deprecation warning when elt command is used instead of el
2 participants
@edgarrmondragon @WillDaSilva