fix: Display a better error message when database URI is null #8015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for meltano canceled.
|
edgarrmondragon
force-pushed
the
8014-bug-exception-thrown-due-to-missing-environment-variable-for-database_uri-could-be-much-clearer
branch
from
105d857
to
610474b
Compare
Codecov Report
@@ Coverage Diff @@
## main #8015 +/- ##
=======================================
Coverage 89.53% 89.54%
=======================================
Files 297 297
Lines 21903 21921 +18
Branches 2443 2446 +3
=======================================
+ Hits 19611 19629 +18
Misses 1936 1936
Partials 356 356
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…ironment-variable-for-database_uri-could-be-much-clearer
…ironment-variable-for-database_uri-could-be-much-clearer
WillDaSilva
approved these changes
Aug 14, 2023
edgarrmondragon
deleted the
8014-bug-exception-thrown-due-to-missing-environment-variable-for-database_uri-could-be-much-clearer
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
database_uricould be much clearer #8014