Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Redact DB password from logs #8031

Merged
merged 3 commits into from
Aug 16, 2023
Merged

fix: Redact DB password from logs #8031

merged 3 commits into from
Aug 16, 2023

Conversation

WillDaSilva
Copy link
Member

Tested manually by checking the output of:

  • meltano --log-level debug invoke tap-github --database-uri postgres://localhost:5432/path
  • meltano --log-level debug invoke tap-github --database-uri postgres://token@localhost:5432/path
  • meltano --log-level debug invoke tap-github --database-uri postgres://user:pass@localhost:5432/path

Closes #6721

@WillDaSilva WillDaSilva self-assigned this Aug 16, 2023
@netlify
Copy link

netlify bot commented Aug 16, 2023

Deploy Preview for meltano canceled.

Name Link
🔨 Latest commit 0cc6aa3
🔍 Latest deploy log https://app.netlify.com/sites/meltano/deploys/64dce573a4686200080d08fc

src/meltano/core/db.py Dismissed Show dismissed Hide dismissed
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #8031 (0cc6aa3) into main (5e2b5fe) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #8031      +/-   ##
==========================================
- Coverage   89.55%   89.54%   -0.02%     
==========================================
  Files         297      297              
  Lines       21921    21924       +3     
  Branches     2446     2446              
==========================================
  Hits        19632    19632              
- Misses       1933     1936       +3     
  Partials      356      356              
Files Changed Coverage Δ
src/meltano/core/db.py 81.70% <100.00%> (+0.69%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@WillDaSilva WillDaSilva requested a review from a team August 16, 2023 15:30
@WillDaSilva WillDaSilva merged commit cb26232 into main Aug 16, 2023
42 of 43 checks passed
@WillDaSilva WillDaSilva deleted the 6721-no-db-pw-in-logs branch August 16, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EL log files should not contain secrets
2 participants