Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Log Meltano version and Operating System at invocation of CLI #8184

Merged
merged 9 commits into from
Nov 10, 2023

Conversation

ashu565
Copy link
Contributor

@ashu565 ashu565 commented Sep 25, 2023

-Added Meltano and Operating System Version at invocation of CLI.(Logger debug level)

@netlify
Copy link

netlify bot commented Sep 25, 2023

Deploy Preview for meltano canceled.

Name Link
🔨 Latest commit 11d338d
🔍 Latest deploy log https://app.netlify.com/sites/meltano/deploys/654eb96f4402720008a96df1

@ashu565 ashu565 changed the title Feature : Added Meltano and Operating System Version at invocation of CLI Feature: Added Meltano and Operating System Version at invocation of CLI Sep 25, 2023
@ashu565 ashu565 changed the title Feature: Added Meltano and Operating System Version at invocation of CLI feat: Added Meltano and Operating System Version at invocation of CLI Sep 25, 2023
@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Merging #8184 (11d338d) into main (72530e9) will decrease coverage by 0.02%.
Report is 3 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #8184      +/-   ##
==========================================
- Coverage   90.92%   90.91%   -0.02%     
==========================================
  Files         244      244              
  Lines       19269    19272       +3     
  Branches     2171     2171              
==========================================
  Hits        17521    17521              
- Misses       1425     1428       +3     
  Partials      323      323              
Files Coverage Δ
src/meltano/cli/cli.py 83.78% <100.00%> (+0.68%) ⬆️
tests/meltano/cli/test_elt.py 96.45% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

src/meltano/cli/__init__.py Outdated Show resolved Hide resolved
src/meltano/cli/__init__.py Outdated Show resolved Hide resolved
@edgarrmondragon
Copy link
Collaborator

Thanks @ashu565! I requested some changes.

@edgarrmondragon edgarrmondragon changed the title feat: Added Meltano and Operating System Version at invocation of CLI feat: Log Meltano version and Operating System at invocation of CLI Sep 25, 2023
@edgarrmondragon edgarrmondragon linked an issue Sep 25, 2023 that may be closed by this pull request
@edgarrmondragon
Copy link
Collaborator

@ashu565 Can you fix the failing tests?

@edgarrmondragon
Copy link
Collaborator

@ashu565 Are you still interested in working on this PR?

@edgarrmondragon edgarrmondragon merged commit 1cdc90c into meltano:main Nov 10, 2023
47 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: Print/log Meltano version at the start of execution
2 participants