Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): Emit pip installation errors #8354

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

edgarrmondragon
Copy link
Collaborator

Fixes #8170

Copy link

netlify bot commented Jan 13, 2024

Deploy Preview for meltano canceled.

Name Link
🔨 Latest commit b7179a0
🔍 Latest deploy log https://app.netlify.com/sites/meltano/deploys/65a6af2895ae850008b4a6d8

Copy link

codecov bot commented Jan 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (224f5aa) 90.89% compared to head (b7179a0) 90.89%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8354      +/-   ##
==========================================
- Coverage   90.89%   90.89%   -0.01%     
==========================================
  Files         244      244              
  Lines       19032    19031       -1     
  Branches     2129     2129              
==========================================
- Hits        17299    17298       -1     
+ Misses       1415     1414       -1     
- Partials      318      319       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/fix/8170-emit-pip-error branch from 43e3747 to 8e71cf2 Compare January 16, 2024 03:01
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/fix/8170-emit-pip-error branch from 8e71cf2 to b7179a0 Compare January 16, 2024 16:30
@edgarrmondragon edgarrmondragon marked this pull request as ready for review January 16, 2024 16:31
@edgarrmondragon edgarrmondragon requested review from WillDaSilva and a team January 16, 2024 16:31
Copy link
Member

@WillDaSilva WillDaSilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@edgarrmondragon edgarrmondragon merged commit b11090d into main Jan 16, 2024
49 of 50 checks passed
@edgarrmondragon edgarrmondragon deleted the edgarrmondragon/fix/8170-emit-pip-error branch January 16, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

break: meltano install no longer shows the pip subprocess logs during a failure
2 participants