fix: --from-ref for a plugin definition missing a variant
#8379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for meltano canceled.
|
ReubenFrankel
changed the title
for a plugin definition missing a variant`--from-ref for a plugin definition missing a variant
edgarrmondragon
approved these changes
Jan 26, 2024
ReubenFrankel
deleted the
fix/from-ref-plugin-definition-missing-variant
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working on #8378, I found that trying to add from a plugin definition YAML file throws an ambiguous error when
variantis missing - it seems to be required when publishing to Meltano Hub, but not by Meltano itself for a custom plugin.During local development of a plugin, I'd imagine a user would initially want to supply a minimal definition (at least on par with what is prompted for in the
--customflow, which doesn't includevariantcurrently) and build it up as they go, so this helps towards that. See the example plugin definition from #8378 for more context.