Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: State from interrupted pipelines or using the --merge-state flag no longer causes crashes #8542

Conversation

edgarrmondragon
Copy link
Collaborator

Copy link

netlify bot commented May 14, 2024

Deploy Preview for meltano canceled.

Name Link
🔨 Latest commit 7f80eb5
🔍 Latest deploy log https://app.netlify.com/sites/meltano/deploys/664400fa699a330008670367

Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.83%. Comparing base (099500d) to head (7f80eb5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8542      +/-   ##
==========================================
+ Coverage   91.78%   91.83%   +0.04%     
==========================================
  Files         245      245              
  Lines       19325    19337      +12     
  Branches     2149     2152       +3     
==========================================
+ Hits        17738    17758      +20     
+ Misses       1313     1306       -7     
+ Partials      274      273       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon force-pushed the 8541-bug-partial-state-causes-failure-when-using-a-filesystem-based-state-backend branch 8 times, most recently from 8304c1f to 1752a23 Compare May 15, 2024 00:07
@edgarrmondragon edgarrmondragon force-pushed the 8541-bug-partial-state-causes-failure-when-using-a-filesystem-based-state-backend branch from 1752a23 to 7f80eb5 Compare May 15, 2024 00:25
@edgarrmondragon edgarrmondragon marked this pull request as ready for review May 15, 2024 02:23
@edgarrmondragon edgarrmondragon requested a review from a team May 15, 2024 16:41
@edgarrmondragon edgarrmondragon added this pull request to the merge queue May 15, 2024
Merged via the queue into main with commit 5c69bff May 15, 2024
50 checks passed
@edgarrmondragon edgarrmondragon deleted the 8541-bug-partial-state-causes-failure-when-using-a-filesystem-based-state-backend branch May 15, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Partial state causes failure when using a filesystem-based state backend
2 participants