fix: SQLConnector.table_exists() to use separate table_name and schema_name instead of fully qualified name
#1168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1168 +/- ##
=======================================
Coverage 83.57% 83.58%
=======================================
Files 42 42
Lines 3873 3874 +1
Branches 657 657
=======================================
+ Hits 3237 3238 +1
Misses 473 473
Partials 163 163
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@edgarrmondragon when you get a chance, please take a look. I left the logging in to show the points I was looking at. I am planning on removing them before I click |
BuzzCutNorman
requested review from
edgarrmondragon,
cjohnhanson and
aaronsteers
as code owners
aaronsteers
reviewed
Nov 11, 2022
aaronsteers
reviewed
Nov 11, 2022
edgarrmondragon
requested changes
Nov 11, 2022
edgarrmondragon
changed the title
SQLConnector.table_exists() to use separate table_name and schema_name instead of fully qualified name
edgarrmondragon
approved these changes
Nov 11, 2022
|
LGTM! Thanks, @BuzzCutNorman 😄 |
BuzzCutNorman
deleted the
1167-fix-table-exists-to-use-tablename-and-schema
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix
table_exists()to use the parsedfull_table_nameparts table and schema instead of a combined multipart name.Fixes #1167
📚 Documentation preview 📚: https://meltano-sdk--1168.org.readthedocs.build/en/1168/