feat(deps): Bump latest supported sqlalchemy from 1.* to 2.*
#1484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
requested review from
a team,
edgarrmondragon,
cjohnhanson and
aaronsteers
as code owners
dependabot
bot
force-pushed
the
dependabot/pip/sqlalchemy-2.0.5.post1
branch
from
bcdea80
to
abdcc57
Compare
dependabot
bot
force-pushed
the
dependabot/pip/sqlalchemy-2.0.5.post1
branch
2 times, most recently
from
88fdc5f
to
10d7f5f
Compare
|
A newer version of sqlalchemy exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
edgarrmondragon
changed the title
edgarrmondragon
force-pushed
the
dependabot/pip/sqlalchemy-2.0.5.post1
branch
from
eaa4188
to
6e03345
Compare
edgarrmondragon
changed the title
edgarrmondragon
changed the title
edgarrmondragon
changed the title
1.* to 2.*
edgarrmondragon
changed the title
1.* to 2.*1.* to 2.*
Codecov Report
@@ Coverage Diff @@
## main #1484 +/- ##
=======================================
Coverage 86.68% 86.68%
=======================================
Files 59 59
Lines 5000 5000
Branches 811 811
=======================================
Hits 4334 4334
Misses 470 470
Partials 196 196
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Bumps [sqlalchemy](https://github.com/sqlalchemy/sqlalchemy) from 1.4.46 to 2.0.5.post1. - [Release notes](https://github.com/sqlalchemy/sqlalchemy/releases) - [Changelog](https://github.com/sqlalchemy/sqlalchemy/blob/main/CHANGES.rst) - [Commits](https://github.com/sqlalchemy/sqlalchemy/commits) --- updated-dependencies: - dependency-name: sqlalchemy dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
This reverts commit 4bcc9ef.
edgarrmondragon
force-pushed
the
dependabot/pip/sqlalchemy-2.0.5.post1
branch
from
e0a8e64
to
f2513fe
Compare
edgarrmondragon
force-pushed
the
dependabot/pip/sqlalchemy-2.0.5.post1
branch
from
bc6b0f4
to
59ed35c
Compare
edgarrmondragon
force-pushed
the
dependabot/pip/sqlalchemy-2.0.5.post1
branch
from
59ed35c
to
221a15c
Compare
edgarrmondragon
approved these changes
Jul 14, 2023
| if isinstance(records, list) | ||
| else (self.conform_record(record) for record in records) | ||
| ) | ||
| conformed_records = [self.conform_record(record) for record in records] |
There was a problem hiding this comment.
execute doesn't really support generators, only sequences (i.e. lists, tuples)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.*and add a single new test against SQLAlchemy1.*. Version is printed in the Pytest output:📚 Documentation preview 📚: https://meltano-sdk--1484.org.readthedocs.build/en/1484/
> **Note**