Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(templates): Update cookiecutter copyright assignment to cookiecutter user #1829

Merged
merged 2 commits into from
Jul 10, 2023

Conversation

riordan
Copy link
Contributor

@riordan riordan commented Jul 10, 2023

Addresses

Assigns copyright in the current year (not 2021) and to the admin_name set in the cookiecutter workflow.


Should this be merged, I'd happily submit a PR to do the same for:

This is, of course, conditional on whether or not we want to encourage MIT licensing within the Meltano/Singer community (as Apache-2 comes with explicit patent usage license, whereas MIT does not).

Closes #1828


📚 Documentation preview 📚: https://meltano-sdk--1829.org.readthedocs.build/en/1829/

@riordan riordan changed the title Update cookiecutter copyright assignment fix(templates): Update cookiecutter copyright assignment to creator Jul 10, 2023
@riordan riordan changed the title fix(templates): Update cookiecutter copyright assignment to creator fix(templates): Update cookiecutter copyright assignment to cookiecutter user Jul 10, 2023
Copy link
Collaborator

@edgarrmondragon edgarrmondragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @riordan, this LGTM!

If you're willing to submit a PR for #1807 then I'd be happy to review it.

@edgarrmondragon edgarrmondragon merged commit 17114e4 into meltano:main Jul 10, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Copyright assignment of new taps/sinks to Meltano.
2 participants