Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle decimal.Decimal instances in flattening #1939

Merged
merged 5 commits into from
Sep 11, 2023

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Sep 6, 2023

Closes #1400


📚 Documentation preview 📚: https://meltano-sdk--1939.org.readthedocs.build/en/1939/

@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Merging #1939 (e74ffd1) into main (99e4446) will increase coverage by 0.00%.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1939   +/-   ##
=======================================
  Coverage   86.97%   86.98%           
=======================================
  Files          59       59           
  Lines        5091     5093    +2     
  Branches      825      826    +1     
=======================================
+ Hits         4428     4430    +2     
  Misses        466      466           
  Partials      197      197           
Files Changed Coverage Δ
singer_sdk/helpers/_flattening.py 72.50% <100.00%> (+0.70%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@edgarrmondragon edgarrmondragon merged commit 0fb0c1b into main Sep 11, 2023
28 checks passed
@edgarrmondragon edgarrmondragon deleted the fix/handle-decimal-flattening branch September 11, 2023 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Record flattening converts objects to strings at the max depth
1 participant