fix(taps): Hard and soft deletes for handling ACTIVATE_VERSION messages now use the same WHERE clause
#2242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Soft delete is deleting only versions smaller than the latest version Hard delete is deleting smaller and equal. Making both strategies delete only smaller versions.
vitoravancini
requested review from
edgarrmondragon and
kgpayne
as code owners
CodSpeed Performance ReportMerging #2242 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2242 +/- ##
=======================================
Coverage 88.47% 88.47%
=======================================
Files 54 54
Lines 4721 4721
Branches 919 919
=======================================
Hits 4177 4177
Misses 383 383
Partials 161 161 ☔ View full report in Codecov by Sentry. |
edgarrmondragon
changed the title
ACTIVATE_VERSION messages now use the same WHERE clause
edgarrmondragon
approved these changes
Feb 14, 2024
edgarrmondragon
pushed a commit
that referenced
this pull request
Mar 6, 2024
…ages now use the same `WHERE` clause (#2242) fix: using same logic for both hard and soft deletes Soft delete is deleting only versions smaller than the latest version Hard delete is deleting smaller and equal. Making both strategies delete only smaller versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Soft delete is deleting only versions smaller than the latest version .
Hard delete is deleting smaller and equal.
Making both strategies delete only smaller versions.
fixes #2227
📚 Documentation preview 📚: https://meltano-sdk--2242.org.readthedocs.build/en/2242/