Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Null type is now correctly appended as {"type": "null"} to oneOf types #2252

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Feb 19, 2024

This was causing config validation failures in meltano-map-transform: https://github.com/MeltanoLabs/meltano-map-transform/actions/runs/7962941688/job/21737507548?pr=221

Copy link

codspeed-hq bot commented Feb 19, 2024

CodSpeed Performance Report

Merging #2252 will not alter performance

Comparing edgarrmondragon/fix/one-of-append (157c6f2) with main (5e02dac)

Summary

✅ 6 untouched benchmarks

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5e02dac) 88.54% compared to head (157c6f2) 88.54%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2252   +/-   ##
=======================================
  Coverage   88.54%   88.54%           
=======================================
  Files          54       54           
  Lines        4724     4724           
  Branches      920      920           
=======================================
  Hits         4183     4183           
  Misses        380      380           
  Partials      161      161           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon marked this pull request as ready for review February 19, 2024 17:39
@edgarrmondragon edgarrmondragon merged commit da62f9a into main Feb 19, 2024
32 checks passed
@edgarrmondragon edgarrmondragon deleted the edgarrmondragon/fix/one-of-append branch February 19, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant