Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Database disconnects are now handled via SQLAlchemy pool_pre_ping parameter #2258

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Feb 20, 2024

@edgarrmondragon edgarrmondragon linked an issue Feb 20, 2024 that may be closed by this pull request
@edgarrmondragon edgarrmondragon marked this pull request as ready for review February 20, 2024 19:18
Copy link

codspeed-hq bot commented Feb 20, 2024

CodSpeed Performance Report

Merging #2258 will not alter performance

Comparing 2257-feat-handle-database-disconnects-in-sql-taps-and-targets (6d6da57) with main (3e2c3d3)

Summary

✅ 6 untouched benchmarks

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.67%. Comparing base (3e2c3d3) to head (6d6da57).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2258   +/-   ##
=======================================
  Coverage   88.67%   88.67%           
=======================================
  Files          54       54           
  Lines        4732     4732           
  Branches      921      921           
=======================================
  Hits         4196     4196           
  Misses        374      374           
  Partials      162      162           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon changed the title feat: Database disconnects are now handled via SQLAlchemy pool_pre_ping parameter fix: Database disconnects are now handled via SQLAlchemy pool_pre_ping parameter Feb 23, 2024
@edgarrmondragon edgarrmondragon merged commit 597291c into main Feb 23, 2024
32 checks passed
@edgarrmondragon edgarrmondragon deleted the 2257-feat-handle-database-disconnects-in-sql-taps-and-targets branch February 23, 2024 15:10
edgarrmondragon added a commit that referenced this pull request Mar 6, 2024
…ng` parameter (#2258)

feat: Database disconnects are now handled via SQLAlchemy `pool_pre_ping` parameter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Handle database disconnects in SQL taps and targets
1 participant