Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): Limited importlib-resources to < 6.2 due to breaking changes #2310

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Mar 12, 2024

Copy link

codspeed-hq bot commented Mar 12, 2024

CodSpeed Performance Report

Merging #2310 will not alter performance

Comparing edgarrmondragon/fix/importlib-resources (d08197e) with main (0d54ebe)

Summary

✅ 6 untouched benchmarks

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.76%. Comparing base (0d54ebe) to head (d08197e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2310   +/-   ##
=======================================
  Coverage   88.76%   88.76%           
=======================================
  Files          54       54           
  Lines        4769     4769           
  Branches      928      928           
=======================================
  Hits         4233     4233           
  Misses        374      374           
  Partials      162      162           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/fix/importlib-resources branch from c461cc4 to d08197e Compare March 13, 2024 18:46
@edgarrmondragon edgarrmondragon changed the title WIP: Check failures with latest importlib-resources fix(deps): Limited importlib-resources to < 6.2 due to breaking changes Mar 13, 2024
@edgarrmondragon edgarrmondragon marked this pull request as ready for review March 13, 2024 18:47
@edgarrmondragon edgarrmondragon requested review from a team and kgpayne as code owners March 13, 2024 18:47
@edgarrmondragon edgarrmondragon merged commit 2e3aff5 into main Mar 13, 2024
30 checks passed
@edgarrmondragon edgarrmondragon deleted the edgarrmondragon/fix/importlib-resources branch March 13, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant