Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: An error message is now logged every time schema validation fails for any record #2421

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented May 10, 2024

Copy link

codspeed-hq bot commented May 10, 2024

CodSpeed Performance Report

Merging #2421 will not alter performance

Comparing 1272-feature-target-json-schema-validation-should-include-stream-name (e562620) with main (9d0c08b)

Summary

✅ 6 untouched benchmarks

Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.18%. Comparing base (9d0c08b) to head (e562620).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2421   +/-   ##
=======================================
  Coverage   89.18%   89.18%           
=======================================
  Files          54       54           
  Lines        4788     4788           
  Branches      936      936           
=======================================
  Hits         4270     4270           
  Misses        361      361           
  Partials      157      157           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon marked this pull request as ready for review May 10, 2024 01:52
@edgarrmondragon edgarrmondragon merged commit 46c14f6 into main May 10, 2024
34 checks passed
@edgarrmondragon edgarrmondragon deleted the 1272-feature-target-json-schema-validation-should-include-stream-name branch May 10, 2024 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Target json schema validation should include stream name
1 participant