You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR is mostly driven by MeltanoLabs/tap-github#34 for which I proposed to use selected-by-default: false in the catalog.
The SDK does not seem to provide a way to actually set this value on the catalog, so this PR aims to fix that.
It is not quite complete however, as the option does not seem to be correctly handled by the tap (unless I've misunderstood what it should do).
My understanding based on the singer spec:
if selected-by-default is set but not selected on a field, the former will effectively play the role of the latter.
if selected is set, then selected-by-default is ignored.
Does this align with how you understand it?
The text was updated successfully, but these errors were encountered:
This has been marked as stale because it is unassigned, and has not had recent activity. It will be closed after 21 days if no further activity occurs. If this should never go stale, please add the evergreen label, or request that it be added.
Merges add-selected-by-default-props -> main
Migrated from GitLab: https://gitlab.com/meltano/sdk/-/merge_requests/196
This PR is mostly driven by MeltanoLabs/tap-github#34 for which I proposed to use
selected-by-default: false
in the catalog.The SDK does not seem to provide a way to actually set this value on the catalog, so this PR aims to fix that.
It is not quite complete however, as the option does not seem to be correctly handled by the tap (unless I've misunderstood what it should do).
My understanding based on the singer spec:
selected-by-default
is set but notselected
on a field, the former will effectively play the role of the latter.selected
is set, thenselected-by-default
is ignored.Does this align with how you understand it?
The text was updated successfully, but these errors were encountered: