Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve support for selected-by-default option on Property - [opened] #579

Closed
MeltyBot opened this issue Oct 27, 2021 · 2 comments
Closed

Comments

@MeltyBot
Copy link
Contributor

Merges add-selected-by-default-props -> main

Migrated from GitLab: https://gitlab.com/meltano/sdk/-/merge_requests/196


This PR is mostly driven by MeltanoLabs/tap-github#34 for which I proposed to use selected-by-default: false in the catalog.
The SDK does not seem to provide a way to actually set this value on the catalog, so this PR aims to fix that.

It is not quite complete however, as the option does not seem to be correctly handled by the tap (unless I've misunderstood what it should do).
My understanding based on the singer spec:

  • if selected-by-default is set but not selected on a field, the former will effectively play the role of the latter.
  • if selected is set, then selected-by-default is ignored.
    Does this align with how you understand it?
@stale
Copy link

stale bot commented Jul 18, 2023

This has been marked as stale because it is unassigned, and has not had recent activity. It will be closed after 21 days if no further activity occurs. If this should never go stale, please add the evergreen label, or request that it be added.

@stale stale bot added the stale label Jul 18, 2023
@edgarrmondragon
Copy link
Collaborator

Addressed by #1672

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants