Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft: SQLConnector modular discover - [opened] #677

Closed
MeltyBot opened this issue May 29, 2022 · 1 comment
Closed

Draft: SQLConnector modular discover - [opened] #677

MeltyBot opened this issue May 29, 2022 · 1 comment
Labels
gitlab merge request

Comments

@MeltyBot
Copy link
Contributor

Merges sql-connector-modular-discover -> main

Migrated from GitLab: https://gitlab.com/meltano/sdk/-/merge_requests/305

As discussed in Slack: https://meltano.slack.com/archives/C01PKLU5D1R/p1653575557167359

There are situations when SQLAlchemy inspection behavior should be tweaked. It would be nice to tweak only relevant parts without large copy-paste.

I propose a refactor of SQLConnector.discover_catalog_entries and sample_tap_bigquery to illustrate why it's needed.
@edgarrmondragon
Copy link
Collaborator

Duplicate (MR) of #678

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gitlab merge request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@edgarrmondragon @MeltyBot