Propably Wrong Method Signature in EquipmentRepository

[oliveirafilipe]

Hi @Melzar, first: Your boilerplate is helping me a lot since it's my first deep dive in all those great architectural techniques.

I'm reading hgraca's article while reading your code

I was going down trough the stack and found this method:

onion-architecture-boilerplate/src/core/applicationServices/Equipment/EquipmentService.ts

Lines 17 to 25 in 0ec089c

	async createEquipment({
	name,
	userId,
	}: CreateEquipmentRequest): Promise<Equipment> {
	return this.equipmentRepository.addEquipment(
	new AddEquipmentRequest(name, userId)
	);
	}
	}

It is creating an AddEquipmentRequest to pass as parameter, but in the method definition:

onion-architecture-boilerplate/src/infrastructure/database/repository/EquipmentRepository.ts

Lines 79 to 82 in 0ec089c

	async addEquipment({
	name,
	userId,
	}: CreateEquipmentRequest): Promise<Equipment> {

It is expecting CreateEquipmentRequest.

I know that both classes have the same signature:

onion-architecture-boilerplate/src/core/applicationServices/Equipment/requests/CreateEquipmentRequest.ts

Lines 1 to 3 in 0ec089c

	export class CreateEquipmentRequest {
	constructor(public readonly name: string, public readonly userId: string) {}
	}

onion-architecture-boilerplate/src/core/domainServices/Equipment/request/AddEquipmentRequest.ts

Lines 1 to 3 in 0ec089c

	export class AddEquipmentRequest {
	constructor(public readonly name: string, public readonly userId: string) {}
	}

So, is EquipmentRepository class defining the wrong signature for addEquipment method or am i missing something?

Thank you!

[Melzar]

Sorry for late response - looks like my mistake, there should be AddEquipmentRequest in as argument in Repository method :). Thanks for catching that I'll provide small patch. @oliveirafilipe

[Melzar]

@oliveirafilipe I've patched that method, I've also introduced a new pattern to the repository which affects this method. Enjoy and thank's for using this repo :) - Closing this issue.