Implement soft corcking #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FelonEkonom
force-pushed
the
soft-corking
branch
3 times, most recently
from
e4614a5
to
d763bb5
Compare
FelonEkonom
force-pushed
the
soft-corking
branch
from
d763bb5
to
858c2bf
Compare
varsill
reviewed
Jul 26, 2023
varsill
requested changes
Jul 28, 2023
Co-authored-by: Łukasz Kita <lukasz.kita0@gmail.com>
Co-authored-by: Łukasz Kita <lukasz.kita0@gmail.com>
varsill
requested changes
Aug 24, 2023
| Process.sleep(100 * RedemandingSource.sleep_time()) | ||
|
|
||
| Testing.Pipeline.execute_actions(pipeline, notify_child: {:sink, :pause_auto_demand}) | ||
|
|
||
| assert_pipeline_notified(pipeline, :sink, {:buff_no, buff_no}) | ||
| # sink should receive aropund 100 buffers, but the boundary is set to 70, in case of eg. |
There was a problem hiding this comment.
Suggested change
| # sink should receive aropund 100 buffers, but the boundary is set to 70, in case of eg. | |
| # sink should receive around 100 buffers, but the boundary is set to 70, in case of eg. |
| def handle_end_of_stream(_pad, ctx, state) do | ||
| actions = | ||
| Map.values(ctx.pads) | ||
| |> Enum.filter(&(&1.direction == :output and not &1.end_of_stream?)) |
There was a problem hiding this comment.
AFAIK, there is only one pad with direction:output, something might be wrong with that action generation.
Comment on lines
254
to
257
| pad_upperbound = Map.get(state.pads_upperbounds, pad, :infinity) | ||
|
|
||
| actions = | ||
| if pad_counter > pad_upperbound and not ctx.pads[pad].auto_demand_paused? do |
There was a problem hiding this comment.
that pad_counter > pad_upperbound comparison is quite tricky (since we are using :infinity atom) :D
mat-hek
approved these changes
Aug 24, 2023
| if old_value == paused? do | ||
| operation = if paused?, do: "pause", else: "resume" | ||
|
|
||
| Membrane.Logger.debug( |
There was a problem hiding this comment.
Suggested change
| Membrane.Logger.debug( | |
| Membrane.Logger.debug_verbose( |
varsill
approved these changes
Aug 25, 2023
Comment on lines
+268
to
+272
| if ctx.pads.output.end_of_stream? do | ||
| {[], state} | ||
| else | ||
| {[end_of_stream: :output], state} | ||
| end |
There was a problem hiding this comment.
If it's ok that the eos will be send on funnel's output right after first eos from input is received, we can leave it that way
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Jira ticket: https://membraneframework.atlassian.net/browse/MC-213