Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the regex better in Memgraph #641

Closed
Josipmrden opened this issue Apr 2, 2024 · 1 comment · Fixed by #732
Closed

Document the regex better in Memgraph #641

Josipmrden opened this issue Apr 2, 2024 · 1 comment · Fixed by #732
Assignees
Labels
priority: medium (missing info) An additional information can be helpful or interesting, but the absence is not disruptive

Comments

@Josipmrden
Copy link
Contributor

we have 2 related flags --auth-user-or-role-name-regex= and --auth-password-strength-regex=
The regular expression syntax is based on the modified ECMAScript regular expression grammar. The ECMAScript grammar can be found here, while the modifications are described in this document. (if this is applied in all cases, just a quick verification needed), the same (or very similar sentence) should be located near

also, wherever regex is mentioned, we can either link to https://memgraph.com/docs/querying/clauses/where#3-regular-expressions

or some other dedicated place in Memgraph

@Josipmrden Josipmrden added the priority: medium (missing info) An additional information can be helpful or interesting, but the absence is not disruptive label Apr 2, 2024
@kgolubic
Copy link
Collaborator

We have three different regex-related situations:

  1. For regex in WHERE clause, we use Modified ECMAScript regular expression grammar (https://en.cppreference.com/w/cpp/regex/ecmascript)
  2. For text (https://memgraph.com/docs/advanced-algorithms/available-algorithms/text#regexgroups) we use C++ regex https://en.cppreference.com/w/cpp/regex
  3. And for text search (https://memgraph.com/docs/configuration/text-search#regex-search), we use https://github.com/quickwit-oss/tantivy

@kgolubic kgolubic mentioned this issue Apr 29, 2024
10 tasks
@kgolubic kgolubic linked a pull request Apr 29, 2024 that will close this issue
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: medium (missing info) An additional information can be helpful or interesting, but the absence is not disruptive
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants