Skip to content
This repository has been archived by the owner on May 23, 2024. It is now read-only.

Add shellcheck to Github Actions #870

Open
lukaszstolarczuk opened this issue Jan 26, 2023 · 0 comments
Open

Add shellcheck to Github Actions #870

lukaszstolarczuk opened this issue Jan 26, 2023 · 0 comments
Labels
QA: CI Continuous Integration Type: Feature

Comments

@lukaszstolarczuk
Copy link
Collaborator

While the change introduced in the PR: #749 was nice, it wasn't completely done, and now (after rebasing to the latest master), it produces many errors. I'm not sure if all the checks for bash scripts are required, perhaps some of them are "redundant" or just "too aggressive"... or perhaps we should just fix them one by one. For now, it is not our highest priority.

Besides, I'm not sure if tests on our CI were executed properly - my guess is the change around test.sh (which -> command -v to be precise) may lead to unexpected behavior. It would require some deeper diving into this problem.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
QA: CI Continuous Integration Type: Feature
Projects
None yet
Development

No branches or pull requests

1 participant