Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for 1.0 #8

Open
Roger-luo opened this issue Aug 13, 2018 · 4 comments
Open

Support for 1.0 #8

Roger-luo opened this issue Aug 13, 2018 · 4 comments

Comments

@Roger-luo
Copy link

Is this project abandoned? Any plans for 1.0?

@jlapeyre
Copy link

See my fork of this repository. In this fork, a large part of the package is compatible with Julia 1.0.

I have not issued PRs for any of these changes, but can do so if desired.

@jlapeyre
Copy link

jlapeyre commented Oct 3, 2018

On my fork, all of the examples run on v1.0. The repo was not originally designed to be a package, so the code is not organized like a package.

I changed this a bit. But, it is just started.

  1. Move data from ./src to ./resources/data
  2. Rewrite some examples (two or three) as scripts that use the package and put them in ./examples.
  3. Move or copy some code from examples to ./test.

This is all done in many commits, so they may be added selectively.

@memoiry
Copy link
Owner

memoiry commented Oct 9, 2018

@jlapeyre Great job, thanks for you contribution!

  1. I haven't going around Julia Lang for a while so it may take me some time to pick up the new feature. Is there any plan that you may sent a pull request related to this?

  2. Yes, The repository is not originally designed as a package, it's simply a collection of function and class for learning purpose, so the code structure is a little messy

Thanks!

@jlapeyre
Copy link

jlapeyre commented Oct 9, 2018

Yes. I'd be happy to make a pull request. I made some structural changes. You might not be interested in all of them..... Maybe I can start with just the bare minimum to get most things working with Julia 1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants