Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in_far = in_far; #21

Closed
andrewcorrigan opened this issue Feb 15, 2014 · 5 comments
Closed

in_far = in_far; #21

andrewcorrigan opened this issue Feb 15, 2014 · 5 comments

Comments

@andrewcorrigan
Copy link
Contributor

Xcode keeps giving me a warning for line https://github.com/memononen/nanovg/blob/master/src/stb_image.c#L1736

in_far = in_far;

Does this line actually do anything?

@andrewcorrigan
Copy link
Contributor Author

If it's just suppressing an unused variable warning, then how about:

(void)in_far;

I've had a lot of luck with that.

@andrewcorrigan andrewcorrigan mentioned this issue Feb 15, 2014
@memononen
Copy link
Owner

stb_image.c is external depencancy and I'd like to keep it as intact as possible so that it is easy to upgrade it later when necessary.

@andrewcorrigan
Copy link
Contributor Author

I will contact upstream then

@memononen
Copy link
Owner

I think that is good idea to contact Sean.

On a second thought, since the change is so small, I think I'll merge it anyways. It should be easy to catch later if I need to update stb_image.

@andrewcorrigan
Copy link
Contributor Author

Contacted, thanks for merging it meanwhile, which allows me to avoid diverging from upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants