Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix visudo bugs; update the CI #843

Merged
merged 8 commits into from
Jun 25, 2024
Merged

Fix visudo bugs; update the CI #843

merged 8 commits into from
Jun 25, 2024

Conversation

squell
Copy link
Member

@squell squell commented May 9, 2024

CC #833

This also makes some changes which should be fix the CI for at least Rust 1.80 by removing some dead code and other cobwebs. Every change has been put in a seperate commit for easy review.

The penultimate commit ("fix indentation") consists of whitespace-only changes.

In more detail, this PR functionally ensures that:

  • Truncates the sudoers file correctly after it has shrunk
  • Prints file source and position information of errors instead of just saying "syntax error".

Thereby Closing #833

Copy link

codecov bot commented May 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 57.48%. Comparing base (4f93acb) to head (865a7d3).
Report is 12 commits behind head on main.

Current head 865a7d3 differs from pull request most recent head 13e7dcc

Please upload reports for the commit 13e7dcc to get more accurate results.

Files Patch % Lines
src/visudo/mod.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #843      +/-   ##
==========================================
- Coverage   57.98%   57.48%   -0.50%     
==========================================
  Files          75       75              
  Lines       10560    10421     -139     
==========================================
- Hits         6123     5991     -132     
+ Misses       4437     4430       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@squell squell changed the title Truncate sudoers file after editing Truncate sudoers file after editing + fix code beautification uncovered by Rust 1.79 Jun 20, 2024
@squell squell changed the title Truncate sudoers file after editing + fix code beautification uncovered by Rust 1.79 Fix visudo bugs; update the CI Jun 20, 2024
@squell squell linked an issue Jun 20, 2024 that may be closed by this pull request
@squell squell mentioned this pull request Jun 21, 2024
@squell squell added C-cli CLI interface CI Meta-issues related to CI labels Jun 21, 2024
@pvdrz pvdrz added this pull request to the merge queue Jun 25, 2024
Merged via the queue into main with commit 3b09b4c Jun 25, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-cli CLI interface CI Meta-issues related to CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

visudo does not want to remove my text
2 participants