Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix high CPU usage #845

Merged
merged 4 commits into from
Jun 25, 2024
Merged

Fix high CPU usage #845

merged 4 commits into from
Jun 25, 2024

Conversation

squell
Copy link
Member

@squell squell commented Jun 21, 2024

NOTE: #843 should be merged before this one (and then this one rebased on the new main) to fix the clippy issues.

Copy link

codecov bot commented Jun 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 57.96%. Comparing base (865a7d3) to head (bdbf05c).
Report is 16 commits behind head on main.

Current head bdbf05c differs from pull request most recent head 4e6e916

Please upload reports for the commit 4e6e916 to get more accurate results.

Files Patch % Lines
src/exec/use_pty/pipe/mod.rs 0.00% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #845      +/-   ##
==========================================
+ Coverage   57.48%   57.96%   +0.47%     
==========================================
  Files          75       75              
  Lines       10421    10140     -281     
==========================================
- Hits         5991     5878     -113     
+ Misses       4430     4262     -168     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@squell squell removed the request for review from pvdrz June 25, 2024 21:36
Copy link
Member Author

@squell squell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pvdrz Your changes look good to me (if they pass the test suite)! (I can't formally review this PR since I opened it.)

Also again thanks for @AppleSheeple for debugging this issue and proposing the original fix.

@pvdrz pvdrz enabled auto-merge June 25, 2024 22:10
Copy link
Collaborator

@pvdrz pvdrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doing a formal approve

@pvdrz pvdrz added this pull request to the merge queue Jun 25, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 25, 2024
@pvdrz pvdrz added this pull request to the merge queue Jun 25, 2024
Merged via the queue into main with commit 13527c1 Jun 25, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sudo high cpu usage after terminal is closed
2 participants