fix: Bug: Slack rate limit #1386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alikonhz
requested review from
idanasulin2706,
avrhamNeeman,
shay23b and
daniel-davidd
as code owners
|
Hi @alikonhz thanks for the willing to contribute to Memphis, it will be carefully reviewed and we will update over here as soon as we can |
idanasulin2706
requested changes
Dec 4, 2023
There was a problem hiding this comment.
Hi @alikonhz thanks for this amazing PR it would help Memphis a lot.
I left some comments.
Also, you will notice that you have a few conflicts to resolve
…e sendInternalAccountMsgWithEcho when saving notification to the queue
idanasulin2706
requested changes
Dec 13, 2023
There was a problem hiding this comment.
Hi @alikonhz it is very closed to be completed just a few last comments
…notifications filter subject for the notification consumer. Add time.sleep when Slack returns rate limit error
idanasulin2706
requested changes
Dec 17, 2023
There was a problem hiding this comment.
@alikonhz Last improvements that we need are in the comments. Thanks
… In case of rate limit error send NACK with RetryAfter as a delay
idanasulin2706
approved these changes
Jan 4, 2024
There was a problem hiding this comment.
thanks @alikonhz for the amazing work, approved, merged and will be released on the next version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my attempt to fix the issue with Slack notifications being rate limited.
Fixes issue #919