Bugfix: Bad df command #1632
Merged
Bugfix: Bad df command #1632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the filesystem name is to long the result of `df -h /` will end up on two lines. Which causes the following error:
```
panic: runtime error: index out of range [1] with length 1
goroutine 477 [running]:
github.com/memphisdev/memphis/server.getUnixStorageSize()
/go/src/memphis/server/memphis_handlers_monitoring.go:1054 +0x454
github.com/memphisdev/memphis/server.MonitoringHandler.GetSystemComponents({0xc0001ced80?})
/go/src/memphis/server/memphis_cloud.go:382 +0x9be8
github.com/memphisdev/memphis/server.MonitoringHandler.getMainOverviewDataDetails.func2()
/go/src/memphis/server/memphis_cloud.go:1680 +0x45
created by github.com/memphisdev/memphis/server.MonitoringHandler.getMainOverviewDataDetails
/go/src/memphis/server/memphis_cloud.go:1679 +0x2ca
```
Example:
```
/run # df -h /
Filesystem Size Used Available Use% Mounted on
/dev/mapper/cryptvol-root
446.5G 268.3G 170.7G 61% /
```
Solution for this is to force the output in POSIX output format.
```
/run # df -h -P /
Filesystem Size Used Available Capacity Mounted on
/dev/mapper/cryptvol-root 446.5G 268.3G 170.7G 61% /
```
madestreel
requested review from
idanasulin2706,
avrhamNeeman,
shay23b and
daniel-davidd
as code owners
|
Forgot to mention that this is for mention that this is for Memphis v1.4.2 |
idanasulin2706
approved these changes
Jan 13, 2024
There was a problem hiding this comment.
Thanks @madestreel approved and merged, it will be part of 1.4.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the filesystem name is to long the result of
df -h /will end up on two lines. Which causes the following error:Example:
Solution for this is to force the output in POSIX output format.