Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backend for tags #389

Merged
merged 21 commits into from
Oct 12, 2022
Merged

backend for tags #389

merged 21 commits into from
Oct 12, 2022

Conversation

shay23b
Copy link
Contributor

@shay23b shay23b commented Oct 3, 2022

No description provided.

http_server/routes/tags.go Outdated Show resolved Hide resolved
models/stations.go Outdated Show resolved Hide resolved
models/tags.go Outdated Show resolved Hide resolved
models/tags.go Outdated Show resolved Hide resolved
models/tags.go Outdated Show resolved Hide resolved
models/tags.go Outdated Show resolved Hide resolved
models/tags.go Outdated Show resolved Hide resolved
models/tags.go Outdated Show resolved Hide resolved
server/memphis_sdk_handlers.go Outdated Show resolved Hide resolved
server/memphis_handlers_tags.go Outdated Show resolved Hide resolved
@@ -114,6 +114,11 @@ func getStationOverviewData(stationName string, h *server.Handlers) (models.Stat
return models.StationOverviewData{}, err
}

tags, err := h.Tags.GetTagsByStation(station.ID)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add this section to the getAllstations section in the sockets

models/stations.go Show resolved Hide resolved
models/tags.go Outdated Show resolved Hide resolved
server/memphis_handlers.go Outdated Show resolved Hide resolved
server/memphis_handlers.go Outdated Show resolved Hide resolved
server/memphis_handlers_tags.go Outdated Show resolved Hide resolved
server/memphis_handlers_tags.go Outdated Show resolved Hide resolved
server/memphis_handlers_tags.go Outdated Show resolved Hide resolved
server/memphis_handlers_tags.go Outdated Show resolved Hide resolved
server/memphis_handlers_tags.go Outdated Show resolved Hide resolved
models/stations.go Outdated Show resolved Hide resolved
server/memphis_handlers_stations.go Outdated Show resolved Hide resolved
server/memphis_handlers_stations.go Outdated Show resolved Hide resolved
server/memphis_handlers_tags.go Outdated Show resolved Hide resolved
server/memphis_handlers_tags.go Outdated Show resolved Hide resolved
server/memphis_handlers_tags.go Outdated Show resolved Hide resolved
server/memphis_handlers_stations.go Outdated Show resolved Hide resolved
@@ -108,6 +108,8 @@ func removeStationResources(s *Server, station models.Station) error {
return err
}

DeleteTagsByStation(station.ID)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't comment in the right place but under the DeleteTagsByStation implementation there is the same function in comment remove it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's delete tags by schema under it

idanasulin2706
idanasulin2706 previously approved these changes Oct 12, 2022
idanasulin2706
idanasulin2706 previously approved these changes Oct 12, 2022
@idanasulin2706 idanasulin2706 merged commit c6af5a5 into master Oct 12, 2022
@idanasulin2706 idanasulin2706 deleted the tagsBack branch October 12, 2022 12:28
@abrl91 abrl91 mentioned this pull request Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants