Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cupertino Cut/Copy/Paste menus on Android #57

Closed
Panthro opened this issue Dec 17, 2018 · 8 comments
Closed

Cupertino Cut/Copy/Paste menus on Android #57

Panthro opened this issue Dec 17, 2018 · 8 comments
Labels
bug Something isn't working zefyr

Comments

@Panthro
Copy link

Panthro commented Dec 17, 2018

When running a Zefyr Editor in Android the menu to copy&paste are the ones from Cupertino.

Is this a bug or an intented behavior?

@pulyaevskiy
Copy link
Contributor

This is definitely a bug. Thanks for submitting!

@pulyaevskiy pulyaevskiy added bug Something isn't working zefyr labels Dec 17, 2018
@pulyaevskiy
Copy link
Contributor

I'm planning to do some work in coming weeks on refactoring selection overlay including selection toolbar. Will make sure to address this first.

There is a chance I end up rolling a custom implementation of selection toolbar for both platforms given there is interest in features like #53 .

@tdh8316
Copy link

tdh8316 commented May 11, 2019

This bug still occurs. Can I fix it manually or disable menu?

@renanyoy
Copy link

I have same bug but with material in iOS simulator
The getter 'cutButtonLabel' was called on null
when trying to paste

[✓] Flutter (Channel stable, v1.9.1+hotfix.5, on Mac OS X 10.15 19A583, locale en-FR)
[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
[✓] Xcode - develop for iOS and macOS (Xcode 11.1)
[✓] Android Studio (version 3.4)
[✓] VS Code (version 1.39.1)
[✓] Connected device (2 available)

Screenshot 2019-10-19 at 08 20 45

@renanyoy
Copy link

Screenshot 2019-10-19 at 08 20 26

@renanyoy
Copy link

I think it wasn't happening before last flutter upgrade

@renanyoy
Copy link

ah, wrong repo, sorry ;)

@Panthro
Copy link
Author

Panthro commented Oct 30, 2019

I think this issue can be closed now, I have tested and on android new material menu is being shown.

@Panthro Panthro closed this as completed Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working zefyr
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants