Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support vite 3.2.4 #7

Closed
TrendAlan opened this issue Nov 29, 2022 · 3 comments
Closed

Support vite 3.2.4 #7

TrendAlan opened this issue Nov 29, 2022 · 3 comments

Comments

@TrendAlan
Copy link

Will you upate this plugin to support latest version 3.2.4?
Currently the peerDependencies is still '^2.8':

  "peerDependencies": {
    "vite": "^2.8"
  },
@Menci
Copy link
Owner

Menci commented Nov 29, 2022

It works in Vite 3 in my project. Did you find any bug?

@TrendAlan
Copy link
Author

TrendAlan commented Nov 29, 2022

When using npm version > v7, will report peerdependence error.

npm ERR! Found: vite@3.2.4
npm ERR! node_modules/vite
npm ERR!   dev vite@"^3.2.4" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer vite@"^2.8" from vite-plugin-public-path@0.0.3
npm ERR! node_modules/vite-plugin-public-path
npm ERR!   vite-plugin-public-path@"0.0.3" from the root project

Though I can use "npm config set legacy-peer-deps true" as workaround, maybe you just need to update the peerDependencies to support vite 3.x.x

Refer to: https://docs.npmjs.com/cli/v7/using-npm/config#legacy-peer-deps

@Menci
Copy link
Owner

Menci commented Dec 2, 2022

Should be fixed in v1.1.0.

@Menci Menci closed this as completed Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants