Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are all dependencies required to run the software? #3

Closed
MatthewFlamm opened this issue Aug 30, 2023 · 3 comments
Closed

Are all dependencies required to run the software? #3

MatthewFlamm opened this issue Aug 30, 2023 · 3 comments

Comments

@MatthewFlamm
Copy link

MatthewFlamm commented Aug 30, 2023

A lot of packages are installed when doing pip install spicy-vki that do not look neccessary for an end user, for example numpydoc, sphinx, sphinxcontrib-serializinghtml. Consider removing numpydoc and any other non-needed packages from:

REQUIRED = [
"numpy>=1.20",
"matplotlib>=3.3.0",
"scikit-learn>=1.0",
"ipython>=7.16.1",
"scipy>=1.5",
"shapely>=1.7.0",
"numpydoc>=1.1.0"
]

@MatthewFlamm MatthewFlamm changed the title Is numpydoc required to run the software? Are all dependencies required to run the software? Aug 30, 2023
@MatthewFlamm
Copy link
Author

ipython, numpydoc, and matplotlib all look to me only to be related to documentation building, but I haven't tested thoroughly.

@MatthewFlamm
Copy link
Author

Some of these dependencies are not be required for the package itself, but are used in the tutorials or documentation building. In that case, there should be separate instructions for installing the packages or maybe a requirements.txt file that is available for installing the packages for the tutorials. Another option would be to use optional dependencies like pip install spciy-vki[tutorial].

@mendezVKI
Copy link
Owner

I removed "numpydoc>=1.1.0". Concerning the tutorials, we followed your suggestion and created an installation with optional dependencies. This was also updated in the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants